Update to docs to use yarn #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
commented
Feb 20, 2018
| @@ -21,16 +21,16 @@ | |||
|
|
|||
| <!-- generated_getting_started_start --> | |||
|
|
|||
| Install Jest using [`npm`](https://www.npmjs.com/): | |||
| Install Jest using [`yarn`](https://yarnpkg.com/en/package/jest): | |||
There was a problem hiding this comment.
I kept yarn and npm here but switched the order
| @@ -124,7 +124,7 @@ official ESLint plugin. It exposes three rules: | |||
| * [no-identical-title](https://github.com/facebook/jest/blob/master/packages/eslint-plugin-jest/docs/rules/no-identical-title.md) - | |||
| disallows identical titles in test names. | |||
|
|
|||
| You can install it using `npm install eslint-plugin-jest` or | |||
| You can install it using `npm install --save-dev eslint-plugin-jest` or | |||
There was a problem hiding this comment.
Added for parity with the yarn command
Codecov Report
@@ Coverage Diff @@
## master #5624 +/- ##
======================================
Coverage 60.9% 60.9%
======================================
Files 215 215
Lines 7325 7325
Branches 3 3
======================================
Hits 4461 4461
Misses 2863 2863
Partials 1 1Continue to review full report at Codecov.
|
SimenB
approved these changes
Feb 20, 2018
This was referenced Feb 23, 2018
This was referenced Mar 5, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates commands to yarn
Test plan
Reviewed pages manually